search

prob-ml / bliss

Bayesian Light Source Separator
MIT License
40 stars 11 forks source link

Spatially-variant PSF/background reproducability #1053

Closed aakashdp6548 closed 1 month ago

aakashdp6548 commented 1 month ago

Mostly this PR is to reproduce the results and figures from the spatially-variant PSF paper.

I've made some changes to metrics, including:

aakashdp6548 commented 1 month ago

Hey @jeff-regier, here is the code to reproduce the results/figures for the PSF paper. I haven't pulled from main yet so it's not ready to merge, just wanted to get this up as a draft so I don't forget.

I made some changes to the metrics (mentioned in the first post). Can you let me know if these are fine to change, or if they may break someone else's results? I can create a new metric instead but didn't want to increase code bloat...

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 94.07407% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.13%. Comparing base (c0645a3) to head (c795a3f).

Files Patch % Lines
bliss/__init__.py 12.50% 7 Missing :warning:
bliss/encoder/metrics.py 99.20% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1053 +/- ## ========================================== + Coverage 81.03% 82.13% +1.10% ========================================== Files 23 23 Lines 2873 2978 +105 ========================================== + Hits 2328 2446 +118 + Misses 545 532 -13 ``` | [Flag](https://app.codecov.io/gh/prob-ml/bliss/pull/1053/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=prob-ml) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/prob-ml/bliss/pull/1053/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=prob-ml) | `82.13% <94.07%> (+1.10%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=prob-ml#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.