probabl-ai / skore

Skore let's you "Own Your Data Science." It provides a user-friendly interface to track and visualize your modeling results, and perform evaluation of your machine learning models with scikit-learn.
https://probabl.ai
MIT License
11 stars 0 forks source link

Publish release with key-type constraint on project.put #382

Closed MarieS-WiMLDS closed 1 week ago

MarieS-WiMLDS commented 1 week ago

when I do in terminal:
python -m skore create

then in notebook:

# %%
from skore import load

# %%
project = load("project.skore")

# %%
project.put("test1", {"test": 1})
project.put({"test": 1}, "test1")

# %%
project.list_keys()

Last cell outputs:
Capture d’écran du 2024-09-23 17-31-59

and I try to python -m skore launch project.skore, I get an error, and can't open skore app:
Capture d’écran du 2024-09-23 17-25-22

While I would expect an error message when I try to put the object.

MarieS-WiMLDS commented 1 week ago

I'm using skore==0.0.1rc3

thomass-dev commented 1 week ago

@MarieS-WiMLDS This is fixed in #368 . I've created a new release 0.0.1rc4 to include this fix.

thomass-dev commented 1 week ago

~The release pipeline failed, i'm on it.~ Package published!

thomass-dev commented 1 week ago

@MarieS-WiMLDS I'll let you close this issue after testing the new release.

MarieS-WiMLDS commented 1 week ago

it's working with the new release, thanks!