search

probabl-ai / skore

Skore let's you "Own Your Data Science." It provides a user-friendly interface to track and visualize your modeling results, and perform evaluation of your machine learning models with scikit-learn.
https://probabl.ai
MIT License
11 stars 0 forks source link

Frontend workflow is not triggered by dependabot PR #386

Closed thomass-dev closed 5 days ago

thomass-dev commented 1 week ago

In https://github.com/probabl-ai/skore/pull/384 , the frontend PR wasn't triggered by dependabot PR, which is weird. Maybe add "opened" in the constraint of the workflow ?

on:                                   
  pull_request:                       
    types: [synchronize]   # [synchronize, opened] ?           
    paths:                            
      - 'frontend/**'                 
      - Makefile                      
      - .github/workflows/frontend.yml

Take a look at https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions

thomass-dev commented 5 days ago

It was worst than i though: each PR with no activity after its creation was affected.

Example:

The solution is to run backend/frontend workflow when the PR is opened, synchronized and reopened to bind existing commits.