probabl-ai / skore

Skore lets you "Own Your Data Science." It provides a user-friendly interface to track and visualize your modeling results, and perform evaluation of your machine learning models with scikit-learn.
https://skore.probabl.ai
MIT License
85 stars 7 forks source link

Toasts must be dismissed manually #499

Closed tuscland closed 1 month ago

tuscland commented 1 month ago

Is your feature request related to a problem? Please describe.

When a warning or an error is generated in skore-ui, a toast appears. The toast remains displayed until I manually click "dismiss".

Describe the solution you'd like

Describe alternatives you've considered, if relevant

No response

Additional context

Possible enhancements:

augustebaum commented 1 month ago

We can start by implementing auto-dismissal after a timeout. If so, this is ready for dev.

rouk1 commented 1 month ago

We need a visual feedback. Dismissing a toast without showing the "countdown" may be strange for users. @anasstarfaoui did you find the time to get something simple ?

May I do something really basic for now ?

Image

rouk1 commented 1 month ago

As discusses with @anasstarfaoui we will go for something a little bit more fancy.

Image

anasstarfaoui commented 1 month ago

https://www.figma.com/design/MRo6JXvZX49ODk1KKzDVJl/Design-system?node-id=151-42&t=cCni6nVa7EjKOAq6-4

-> link to design system toast page