search

probabl-ai / skore

Skore lets you "Own Your Data Science." It provides a user-friendly interface to track and visualize your modeling results, and perform evaluation of your machine learning models with scikit-learn.
https://probabl-ai.github.io/skore/
MIT License
70 stars 7 forks source link

feat(UI): Clarify how items can be added to a view #542

Closed rouk1 closed 4 weeks ago

rouk1 commented 1 month ago

This PR

UI preview:

https://github.com/user-attachments/assets/c6df8dd6-03ea-4fcd-a254-2eb8747d3d35

tuscland commented 1 month ago

I checked out this branch, have an empty view selected, but when I click the + button it does not add the item to the view. Dragging works though.

https://github.com/user-attachments/assets/7e4c32e3-9dfb-446b-8d06-29a4966ec210

github-actions[bot] commented 4 weeks ago

Coverage Report for ./skore-ui

Status Category Percentage Covered / Total
🔵 Lines 77.84% 1866 / 2397
🔵 Statements 77.84% 1866 / 2397
🔵 Functions 42.34% 47 / 111
🔵 Branches 80% 140 / 175
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
skore-ui/src/components/TreeAccordion.vue 87.5% 100% 0% 87.5% 30-32
skore-ui/src/components/TreeAccordionItem.vue 83.72% 93.33% 10% 83.72% 19-23, 39-43, 45-48
skore-ui/src/views/ComponentsView.vue 83.73% 100% 0% 83.73% 34-36, 38-40, 46-55, 57-61, 63-67, 69-71, 136-143, 145-165, 169-178, 191-195, 199-205
skore-ui/src/views/project/ProjectItemList.vue 57.89% 50% 0% 57.89% 18-24, 26-27, 31-37
Generated in workflow #376 for commit 7ee7df4 by the Vitest Coverage Report Action
rouk1 commented 4 weeks ago

I checked out this branch, have an empty view selected, but when I click the + button it does not add the item to the view. Dragging works though. click-item.mov

Is there some errors in the js console ? I cant reproduce this on my side ?

note: code as been merged