Closed sylvaincom closed 18 minutes ago
Another short enhancement:
To be honest, this issue is getting a bit big. Can we create individual issues?
@augustebaum I created 3 smaller issues.
@sylvaincom, I didn't create issues about For linear regression, it is redundant to say test_r2 and test_score.
because I don't know what kind of design solution you had in mind, nor for the train scores, for the same reason. I'll let you do it :)!
Created to two issues of this larger issue that I would consider a small epic
Now that this has been divided up I'll go ahead and close this
skore.cross_validate`
First PR of this new feature: https://github.com/probabl-ai/skore/pull/443, cc @MarieS-WiMLDS and @augustebaum. Issue: https://github.com/probabl-ai/skore/issues/383. Some issues arose in https://github.com/probabl-ai/skore/pull/443#issuecomment-2419436912, that have been separated to this new GitHub issue. The issue is written again here:
EDIT : after a discussion with @augustebaum, maybe we can keep both, but in all cases, we should say somewhere what is actually behind
test_score
.For the fit time:
Note:
neg_mean_squared_error
is actually meant to be negative and behave like a score (the higher, the better). But still, naming "results" is better I believe.Maybe we can say something like "Cross-validation results" and the y-label is "Results", so that it can be appropriate for scores, errors, and times
EDIT by @augustebaum : Done
plotly
before the first release, because DS are much more familiar withplotly
than withaltair
. See dropdowns in plotly.EDIT: Tis is the new display that does not have a dropdown menu but does the same & it can enable us to compare the training and testing times together which is very useful ; if we had the train score then we can also compare the train and test scores together
https://github.com/user-attachments/assets/51b24679-c789-477f-932f-f590a0ac625b