search

probabl-ai / skore

Skore lets you "Own Your Data Science." It provides a user-friendly interface to track and visualize your modeling results, and perform evaluation of your machine learning models with scikit-learn.
https://probabl-ai.github.io/skore/
MIT License
70 stars 7 forks source link

New view name should increment #708

Closed MarieS-WiMLDS closed 22 hours ago

MarieS-WiMLDS commented 6 days ago

Is your feature request related to a problem? Please describe.

It should be possible imo to create several views without having to name them.
Currently the situation is this one:
image

Describe the solution you'd like

New view iterative number?

Describe alternatives you've considered, if relevant

New new view, new new new view etc, but this seems very bad practice :) !

Additional context

No response

rouk1 commented 6 days ago

Actually we tried to achieve a UX where you can only have one pending rename view. Hence if you chose to keep the new view name then the next view you'll create cant be named "new view" and you'll have a error toast. The idea was to force user to give good names and not keep the placeholder name.

We can do a check if there is a "new view" named view actually then add a + 1 to it but then how would that scale ? Should we do regex capture of the number ?

MarieS-WiMLDS commented 6 days ago

My test is indeed not very representative of a real user behavior (I hope): I tried clicking on the "+" for the view many times to see what happens. This is why it's only P2. Yet, it feels troublesome.

We can do a check if there is a "new view" named view actually then add a + 1 to it but then how would that scale ? Should we do regex capture of the number ?
I like this option of +1. Whatever tech solution you prefer!

tuscland commented 1 day ago

What I did in a past software was to have:

I think it is the best compromise: at the moment, we don't believe there are strict requirements on view naming, and after it's the responsibility of the user to name it as they see fit.