search

probablykasper / cpc

Text calculator with support for units and conversion
https://crates.io/crates/cpc
MIT License
121 stars 14 forks source link

Apply select clippy recommendations #27

Closed jqnatividad closed 1 year ago

jqnatividad commented 1 year ago

Hi @probablykasper , rolled back the if let and consolidated the clippy allows to the beginning of lib.rs. If you want to remove them altogether, lemme know.

It's just that I'm so used to it, since I have clippy on my CI (https://github.com/jqnatividad/qsv/blob/master/.github/workflows/rust-clippy.yml), but I know its a matter of preference.

probablykasper commented 1 year ago

Is there anything you actually need a new cpc release for?

jqnatividad commented 1 year ago

Nothing really in particular. Should you want to hold back a release until a new feature lands, then its OK by me.

FYI, I'll just use the [patch.crates-io] Cargo.toml section to use my fork in the meantime if you'd rather not make a new release.

probablykasper commented 1 year ago

The version updates you did were only minor releases, so if you're using cpc as a dependency I believe cargo will select the latest minor versions anyways