search

probablykasper / starchart

GitHub star history graph
https://starchart.kasper.space
5 stars 0 forks source link

Put repo names in url? #2

Closed boxed closed 4 hours ago

boxed commented 4 hours ago

I like this project much more than star-history.com because of the higher resolution and better interaction, but star-history puts the repos in the url so you can share URLs with people which this project lacks. I think that's a killer feature.

probablykasper commented 4 hours ago

It would be nice, but would kinda need a server to store the star history. I don't expect to spend time on that, though a PR would be welcome

boxed commented 4 hours ago

That's not what I meant. Just put the things the user select into the URL with https://developer.mozilla.org/en-US/docs/Web/API/Location/replace or https://developer.mozilla.org/en-US/docs/Web/API/Location/assign It's a fully client side thing. That's what star-history does.

probablykasper commented 4 hours ago

Fair enough I suppose, just thought it would we weird to link to it when it might take so long to load. Feel free to submit a PR!

boxed commented 4 hours ago

Oh. Hmm. Yea ok, that's a good point.