search

probablyraging / hide-youtube-shorts

Hide YouTube Shorts videos effortlessly with this powerful browser extension
https://hideshorts.com
GNU General Public License v3.0
96 stars 11 forks source link

Still showing shorts in my subscriptions feed #18

Closed RobThree closed 1 year ago

RobThree commented 1 year ago

Describe the issue

I'm still seeing shorts in my subscriptions feed:

image

What version of HYS are you using?

Latest version

What browsers are you seeing the problem on?

Chrome

Latest browser version?

Yes

probablyraging commented 1 year ago

I'm a little confused by the screenshot you've shared. It appears that your Subscriptions page is showing content from channels you're not subscribed to, or they don't appear in the Subscriptions list at the very least.

I also see that your Subscriptions list isn't in alphabetical order as it should be by default. Unless a channel is Live or has a current Premiering video it should be alphabatized. otherwise the channel would be at the top of the list with a red broadcasting icon next to it. However I see that the LTT channel is first in your list regardless of it being live/premiering.

The channels I have marked should appear somewhere in your list, but don't image

Are you using any other extensions for YouTube that allow you to customize your subscriptions by any chance? This could likely cause conflicts between the two extensions.

Come to think of it, I don't recall ever seeing a Shorts Shelf on the Subscriptions page before and I am unable to get one to appear on my own no matter how hard I try, so this could very well be a new thing.

Could you go to the Subscriptions page > right click anywhere on the page > click "view page source", then copy the entire contents of the pages HTML, paste it into a .txt file and upload it here so I can take a look at it? Because as of right now I am unable to repro and no one has mentioned having this issue.

RobThree commented 1 year ago

I'm a little confused by the screenshot you've shared. It appears that your Subscriptions page is showing content from channels you're not subscribed to, or they don't appear in the Subscriptions list at the very least.

I have over 200 subscriptions, they're not in alphabetical order:

Are you using any other extensions for YouTube that allow you to customize your subscriptions by any chance? This could likely cause conflicts between the two extensions.

Nope. I am using the following extensions:

Come to think of it, I don't recall ever seeing a Shorts Shelf on the Subscriptions page before and I am unable to get one to appear on my own no matter how hard I try, so this could very well be a new thing.

I don't know, but I've been seeing them for quite some time on my subscriptions list

Could you go to the Subscriptions page > right click anywhere on the page > click "view page source", then copy the entire contents of the pages HTML, paste it into a .txt file and upload it here so I can take a look at it? Because as of right now I am unable to repro and no one has mentioned having this issue.

Sure. Here you go. (I have taken the liberty to 'tidy' the HTML a little).

FWIW: My subscriptions bookmark links to: https://www.youtube.com/feed/subscriptions?flow=2 which gets redirected to https://www.youtube.com/feed/subscriptions. Not sure what the flow=2 does (or, more likely, did) but going to https://www.youtube.com/feed/subscriptions directly still shows the shorts. And, again, I've been seeing them there for quite a while now. Like, months at least.

probablyraging commented 1 year ago

I have over 200 subscriptions, they're not in alphabetical order:

Hmm, maybe after a certain number of subscriptions YouTube just stops ordering them lol not sure

Sure. Here you go. (I have taken the liberty to 'tidy' the HTML a little).

Sorry, my mistake, forgot YouTube renders everything dynamically so no useful data from viewing the page source. Instead, can you follow the same steps but instead of clicking "view page source" click "inspect element", wait for the dev tools window to popup, scroll right to the top of the element tab, right click the opening tag, go down to copy > copy element. Paste that in a .txt file and send that instead. Just make sure the page had completely finished rendering all the videos and stuff.

FWIW: My subscriptions bookmark links to: https://www.youtube.com/feed/subscriptions?flow=2 which gets redirected to https://www.youtube.com/feed/subscriptions. Not sure what the flow=2 does (or, more likely, did) but going to https://www.youtube.com/feed/subscriptions directly still shows the shorts. And, again, I've been seeing them there for quite a while now. Like, months at least.

Thanks. Yeah flow=1 and flow=2 are just the difference between Grid and List view. flow=2 being List view which is what you're using based off the screenshot. Does the Shorts Shelf only appear in List view or is it in Grid view as well?

RobThree commented 1 year ago

Sorry, my mistake [...] Paste that in a .txt file and send that instead.

Here you go

Does the Shorts Shelf only appear in List view or is it in Grid view as well?

I don't seem to get shorts in the grid view.

I also tried disabling Adblock Pro but no difference.

probablyraging commented 1 year ago

Here you go

Thanks for doing that mate.

I believe I've fixed this issue. Though, I can't push the fix as a update to the CWS version until I can verify it works and doesn't break anything else (though it likely won't).

If you're up for it, would you mind testing to see if it works? You can download the .zip file from this branch, install the unpacked version following these steps. Make sure you disable the official version first. Just test it out for a few days and report back.

If not, I will have to wait until I can somehow verify it myself.

RobThree commented 1 year ago

If you're up for it, would you mind testing to see if it works?

I won't mind at all. But I'll have to leave that for tomorrow or later this week, sorry.

RobThree commented 1 year ago

I downloaded the zip-file, extracted it, extensions are already in developer mode, clicked load unpacked, selected the unpacked directory and then I get:

Screenshot 2023-06-11 at 12 32 26
probablyraging commented 1 year ago

I downloaded the zip-file, extracted it, extensions are already in developer mode, clicked load unpacked, selected the unpacked directory and then I get:

Sorry mate, give this a try, make sure the folder you're selecting has manifest.json in the root

hide-youtube-shorts-1.6.9-b.zip

RobThree commented 1 year ago

That properly installed.

Can confirm shorts are now gone though I saw them briefly before they disappeared. I think this is 'by design'?

probablyraging commented 1 year ago

Good to hear!

Yeah, you will usually see a quick glimpse of them before they dissapear as the context script waits for the DOM to be loaded before it starts running any functions to remove elements.

But glad to hear it's working. Test it out for a few days and let me know if you have any issues at all. If all is good I will merge it with the main branch 🍻

RobThree commented 1 year ago

I haven't seen any shorts since! 👍 I think it's safe to add this.

probablyraging commented 1 year ago

I haven't seen any shorts since! 👍 I think it's safe to add this.

Thank you for testing mate. Have added this fix and it should be live on CWS within 24 hours 🍻