probberechts / soccerdata

⛏⚽ Scrape soccer data from Club Elo, ESPN, FBref, FiveThirtyEight, Football-Data.co.uk, FotMob, Sofascore, SoFIFA, Understat and WhoScored.
https://soccerdata.readthedocs.io/en/latest/
Other
529 stars 90 forks source link

[SoFIFA] Adjust to new HTML structure #452

Closed probberechts closed 6 months ago

probberechts commented 6 months ago

This commit adapts the SoFIFA reader to work with the new HTML structure. Furthermore, it extends the number of ratings scraped by "read_team_ratings".

Make sure to delete the SoFIFA cache before updating!

Fixes #449

codecov-commenter commented 6 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (86754b2) 60.82% compared to head (deb59ea) 60.70%. Report is 1 commits behind head on master.

Files Patch % Lines
soccerdata/sofifa.py 0.00% 10 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #452 +/- ## ========================================== - Coverage 60.82% 60.70% -0.13% ========================================== Files 10 10 Lines 1450 1453 +3 Branches 298 300 +2 ========================================== Hits 882 882 - Misses 521 524 +3 Partials 47 47 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.