search

probberechts / soccerdata

⛏⚽ Scrape soccer data from Club Elo, ESPN, FBref, FiveThirtyEight, Football-Data.co.uk, FotMob, Sofascore, SoFIFA, Understat and WhoScored.
https://soccerdata.readthedocs.io/en/latest/
Other
544 stars 95 forks source link

[General] Tor port is not up to date #83

Closed david-leconte closed 1 year ago

david-leconte commented 1 year ago

(seen on Windows 11)

The Tor port specified in the code for when initializing a scraper with the proxy="tor" option is 9050, whereas the new Tor versions seem to use port 9150.

Something should be done to check whether port 9050 works in the first place and if it doesn't check with 9150.

For other people it doesn't work for right now, you can always do this :

return_proxies = lambda: {
    "http": "socks5://127.0.0.1:9150",
    "https": "socks5://127.0.0.1:9150",
}

ws = sd.WhoScored(leagues="ENG-Premier League", seasons=20-21, proxy=return_proxies)
probberechts commented 1 year ago

I've just updated Tor and it still defaults to port 9050. Did you perhaps install the Tor Browser Bundle? That distribution indeed defaults to listening on port 9150.

probberechts commented 1 year ago

Anyway, thanks for raising the issue. I think it would be good to add this to the docs.

david-leconte commented 1 year ago

The only difference from a regular installation was that I downloaded the Tor files and executable from a German mirror due to DNS blocking, maybe that's what it is.

No problem, thanks for adressing the issue!

Le mar. 27 sept. 2022 à 19:32, Pieter Robberechts @.***> a écrit :

Anyway, thanks for raising the issue. I think it would be good to add this to the docs.

— Reply to this email directly, view it on GitHub https://github.com/probberechts/soccerdata/issues/83#issuecomment-1259830838, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARCRI277WXMNFMJRSOTS6ZLWAMVRPANCNFSM6AAAAAAQVEPBXA . You are receiving this because you authored the thread.Message ID: @.***>