pickling in ascii mode can corrupt metadata

probcomp / BayesDB

A Bayesian database table for querying the probable implications of data as easily as SQL databases query the data itself. New implementation in http://github.com/probcomp/bayeslite

http://probcomp.csail.mit.edu/software/bayesdb/

Apache License 2.0

891 stars 52 forks source link

pickling in ascii mode can corrupt metadata #57

Closed fiendish closed 9 years ago

fiendish commented 9 years ago

Pickling without explicitly setting mode +'b' causes metadata corruption on some systems (e.g. Windows). Python pickle docs say binary mode should always be used for protocols higher than 0.

probcomp-gh-bot commented 9 years ago

Can one of the admins verify this patch?

BaxterEaves commented 9 years ago

ok to test