search

probcomp / Gen.jl

A general-purpose probabilistic programming system with programmable inference
https://gen.dev
Apache License 2.0
1.79k stars 160 forks source link

Doc clarification for "regenerate" and "update" #486

Closed fsaad closed 1 year ago

fsaad commented 1 year ago

Demystify the returned weight of "update" and "regenerate" as difference.

The current log weight is hard to read, breaking it into a difference of log weights make the spec clearer. (Please double check).

ztangent commented 1 year ago

Looks right to me! How do we get the checks to run?

fsaad commented 1 year ago

Looks right to me! How do we get the checks to run?

I'm not sure... maybe https://github.com/probcomp/Gen.jl/pull/484 needs to be merged into master first?

EDIT: I think pushing a dummy commit will trigger the checks too.

EDIT (2): I think pushing the dummy commit did in fact trigger the checks... they are in progress.