search

probcomp / Gen.jl

A general-purpose probabilistic programming system with programmable inference
https://gen.dev
Apache License 2.0
1.79k stars 160 forks source link

Simplified import from `Distributions.jl` #493

Open lrnv opened 1 year ago

lrnv commented 1 year ago

Hi,

I would like to know if it was on purpose that distributions are re-implemented and not pulled from Distributions.jl framework ? And why so ?

Is there / could there be a standardized way to import a distribution from Distributions.jl ? If you think that is possible, I am willing to take a look and maybe draft a PR :)

In particular, I would love to be able to import my multivariate distributions from Copulas.jl's SklarDist type.

ztangent commented 1 year ago

We decided to implement a separate interface for distributions for greater modularity and evolvability, but GenDistributions.jl should implement the functionality you're asking for!

@alex-lew perhaps we can update the docs and website to make this package more visible?

lrnv commented 1 year ago

Thanks ! I knew that someone needed this before me :) Indeed, flagging it in the docs would be a great idea. Maybe inside https://www.gen.dev/docs/stable/ref/distributions/, as a fifth section Import a distribution from Distributions.jl that simply re-gives the readme.md of GenDistributions ?