Panoply of lint errors

[gregory-marton]

710 no-member 468 undefined-variable 29 no-name-in-module 15 unexpected-keyword-arg 9 too-many-function-args 8 function-redefined 4 invalid-sequence-index 2 method-hidden 1 too-many-format-args

TODO:

• Exclude third-party libraries from lint
• Module no-member errors are generally caused by pylint not understanding metaprogramming. We can add guilty modules to the no-member exclusion list that I saw you start, ideally after nominally checking the third-party ones. In our code, venture.lite.types is metaprogrammed, so that can be added to the exclusion list.
• Make it clear what the members of each class are, e.g. by initializing them all in init and never add more later.
• Extend pylint to recognize lists in boolean context and suggest len(lst) > 0 or similar instead.

[axch]

Updated set, computed with Grem's work-in-progress lint config for Bayeslite. Still todo:

• Exclude venture.lite.types no-member errors
• Exclude lint in external/ code

233 E1101 no-member 45 E0602 undefined-variable 14 E0611 no-name-in-module 9 E1121 too-many-function-args 4 E0102 function-redefined 1 E1305 too-many-format-args 1 E0202 method-hidden

lints.txt

I anticipate killing the code identified in the rest of the System Simplification milestone will further reduce the count of contentful lint errors.