search

probcomp / Venturecxx

Primary implementation of the Venture probabilistic programming system
http://probcomp.csail.mit.edu/venture/
GNU General Public License v3.0
28 stars 6 forks source link

Should we change the distribution equality test in the test suite? #315

Open axch opened 8 years ago

axch commented 8 years ago

Right now it uses either one-sample or two-sample chi^2, depending on whether one of the desired distributions is assessable. I recently found myself investigating the wisdom and appropriateness of this choice; results at https://github.com/probcomp/Venturecxx/blob/master/doc/on-comparing-discrete-distributions.md . Should we actually change anything?

riastradh-probcomp commented 8 years ago

For the record, the G-test is identical up to a multiplicative constant to what Jaynes calls the psi-test in Sec. 9.11 'Significance tests'.