probcomp / Venturecxx

Primary implementation of the Venture probabilistic programming system
http://probcomp.csail.mit.edu/venture/
GNU General Public License v3.0
28 stars 6 forks source link

exp, log, log1p #609

Open riastradh-probcomp opened 8 years ago

riastradh-probcomp commented 8 years ago

Proposal: In utils.py, rename

Import these unqualified and use them consistently, instead of math.* or numpy.*, wherever a single point is required. Continue to use numpy.* consistently where vectorization may be needed.

Rationale:

axch commented 8 years ago

Sounds good to me. This is an acceptable resolution to #534.

riastradh-probcomp commented 8 years ago

Whoops. I thought there was a related issue but overlooked #534 when I went looking for it a few minutes ago.

riastradh-probcomp commented 8 years ago

Addendum: Define expm1 in utils.py too.