search

probcomp / Venturecxx

Primary implementation of the Venture probabilistic programming system
http://probcomp.csail.mit.edu/venture/
GNU General Public License v3.0
28 stars 6 forks source link

add travis-ci.org and conda package functionality #681

Closed avinson closed 7 years ago

avinson commented 7 years ago

@axch making an attempt to clean this up a bit. one issue i'm running into is that this small change:

https://github.com/probcomp/Venturecxx/commit/51e241d5e37c164c08eac71b1fdbf9b4c26b9690

causes builds to fail:

https://travis-ci.org/probcomp/Venturecxx/builds/298414403

the error is: ImportError: libgfortran.so.1: cannot open shared object file: No such file or directory

at a bit of a loss to explain this.. i also tried scipy >=0.13,<=0.19.* with no luck.. perhaps it's some idiosyncrasy of conda or perhaps we need to add libgfortran/libgfortran-ng to build requirements. going to remove the max version for now so builds will pass this part.

axch commented 7 years ago

libgfortran? Venture shouldn't have any direct dependency on it, so that must be going through scipy. But then, why wouldn't other packages have the same problem? Any chance it's a diamond dependency?

avinson commented 7 years ago

@axch i added back requires for testing but leaving them out for install -- reason why is that the install directive is needed to build conda package and we're planning to manage runtime dependencies in meta.yaml.

also, i think we can safely leave scipy >=0.13 and not specify a maximum version. the actual runtime environment will primarily be controlled by the Dockerfile

lmk if you'd like me to squash commits prior to merge