search

probcomp / bayeslite

BayesDB on SQLite. A Bayesian database table for querying the probable implications of data as easily as SQL databases query the data itself.
http://probcomp.csail.mit.edu/software/bayesdb
Apache License 2.0
922 stars 64 forks source link

Consider removing VERSION, or enforce that people updating tags use it properly/create PRs #612

Closed fsaad closed 6 years ago

fsaad commented 6 years ago

For bayeslite and several other repositories, people pushing tags have not been correctly updating the VERSION file as required. This foresight will cause problems and confusion between git tags, conda release version, the version reported by bayeslite.version in python, and even potentially cause python setup.py build to fail.

We should:

  1. Be explicit that tagging should be done via a PR requested a tag: versioned release tags are managed and approved by a set of disciplined maintainers.

  2. Implement 1., and consider replacing VERSION with the method I am using the trcrpm setup.py file. "Disciplined maintainers" can also mess up VERSION bumping, so something more automated might be better.

I must say I do not know the full reasoning behind why VERSION was designed like this or other python projects which use the convention, but I do believe it is a good convention provided that VERSION bumping was always done correctly.

fsaad commented 6 years ago

Fixed by https://github.com/probcomp/bayeslite/commit/9834694ca07c8e5bde0f34720c0364807259aff3