probcomp / crosscat

A domain-general, Bayesian method for analyzing high-dimensional data tables
http://probcomp.csail.mit.edu/crosscat/
Apache License 2.0
322 stars 42 forks source link

20161116 fsaad diagnostics column partition #109

Closed fsaad closed 8 years ago

fsaad commented 8 years ago

Parent PR: https://github.com/probcomp/crosscat/pull/107

Two reasons for this PR: (i) The current implementation of diagnostic recording fails when the user specifies a max_time with diagnostics_every_N. This is beacuse _each invocation of p_State.transition uses the same max_time inside the for loop over child_n_steps, whereas we really need max_time to apply to the union of calls to p_State.transition.

(ii) The progress bar is now compatible with diagnostic recording, which occurs in the inner loop of State.transition.