probcomp / crosscat

A domain-general, Bayesian method for analyzing high-dimensional data tables
http://probcomp.csail.mit.edu/crosscat/
Apache License 2.0
322 stars 42 forks source link

20160303 alxempirical pass bdb seed to crosscat engine #88

Closed alxempirical closed 8 years ago

alxempirical commented 8 years ago

Please see comments on PR probcomp/bayeslite#382 , which this PR should be applied in concert with.

alxempirical commented 8 years ago

The gpmcc engine class used to create a new pool for every query, which caused huge resource leak.

To address this issue on this branch, I share a pool between engines. Thus it doesn't make sense for the pool to be terminated when the engine is deleted.

However, I should maintain the old behavior for when people construct a MultiProcessingEngine in the old fashion. I'll fix that up.

gregory-marton commented 8 years ago

Superseeded by #92