search

probcomp / hierarchical-irm

Probabilistic structure discovery for rich relational systems
Apache License 2.0
1 stars 1 forks source link

Change DirichletCategorical SampleType from double to int. #47

Closed emilyfertig closed 2 weeks ago

emilyfertig commented 2 weeks ago

The tests etc. already assumed these were ints, which were being implicitly cast to double.

I'm happy to do BetaBernoulli double->bool while I'm at it too, unless you prefer to, just let me know.

ThomasColthurst commented 2 weeks ago

LGTM! You are welcome to do BetaBernoulli as well, as I will be at ChiCon all of today and tomorrow.