probcomp / hierarchical-irm

Probabilistic structure discovery for rich relational systems
Apache License 2.0
1 stars 1 forks source link

Revert "Change nonconjugate class to keep a running logp score" #68

Closed ThomasColthurst closed 1 week ago

ThomasColthurst commented 1 week ago

This reverts commit fc9115366521570c714322746df351b9cebac4d1.

I remembered why it is important to memorize the data and have logp_score compute the log probabilities -- it is because the latent variables can change after the data has been incorporated.

emilyfertig commented 1 week ago

Aha good point.