probcomp / inferenceql.viz

Apache License 2.0
1 stars 0 forks source link

Remove rejection sampling in generator-fn for simulate plots #32

Open harishtella opened 4 years ago

harishtella commented 4 years ago

The generator function used to insert new values into simulate plots uses rejection sampling to reject values that are negative.

https://github.com/probcomp/inferenceql/blob/4403260dc8016d3daeeb873f6e50e8c8604636cc/spreadsheets/src/inferenceql/spreadsheets/panels/viz/subs.cljs#L31

Note: simulate plots are the plots that appear when a single cell is selected in the UI.

In the future we may want to display negative values generated by a model, and in that case this rejection sampling will have to be removed.