probcomp / inferenceql.viz

Apache License 2.0
1 stars 0 forks source link

Only use changed settings in Handsontable update #56

Closed harishtella closed 3 years ago

harishtella commented 3 years ago

What does this do?

Handsontable gets updated with its .updateSettings function which takes a map of settings. Previously, when any of the settings changed, .updateSettings would be called with all the settings again resulting in very slow updates when the dataset was large. (One of the settings is the actual data to display, and this would reload the data whenever any other setting changed.)

Now we only call the .updateSettings function with the settings keys that have changed -- resulting in much faster updates.

Also much of the logic for doing the update has been moved into the update-hot! function with some improvements.

Motivation