Add externs for Javascript deps

probcomp / inferenceql.viz

Apache License 2.0

1 stars 0 forks source link

Add externs for Javascript deps #83

Closed harishtella closed 3 years ago

harishtella commented 3 years ago

What does this do?

This adds a folder of externs for JS dependencies. These extern files were taken from the CLJSJS repos for the various JS deps. Some of the externs, like the one for Handsontable were modified because recent versions of Handsontable have updated the api with new functions not present in the older CLJSJS version.

Motivation

These externs files will be used in a future PR for enabling a Clojurescript advanced compilation build.

zane commented 3 years ago

If these libraries are available in CLJSJS why aren't we getting them from CLJSJS? Are we using a newer version than the one that is available there?

harishtella commented 3 years ago

@zane Yes, for some libs, we are using newer versions.

There are two other things to mention.

1) I went for the Webpack approach because the CLJS/Foreign-Libs approach with advanced compilation does not work with the Observable's require function. I can write more about that, but that was one of the Webpack motivations.

2) Since we are now adding Webpack, it makes more sense to get all our JS-deps just one way. Via node_modules and webpack.