probcomp / iventure

An interactive, browser-based probabilistic programming environment.
Apache License 2.0
14 stars 2 forks source link

Case-sensitive lookups of variable names somewhere in jsviz/vizgpm #38

Closed riastradh-probcomp closed 7 years ago

riastradh-probcomp commented 7 years ago

interactive_pairplot fails to produce a plot, and instead yields Error: unknown column ..., if the query fed to it yields a column name that differs in case from the corresponding column name in the population.

fsaad commented 7 years ago

@riastradh-probcomp please provide a minimum working example.

riastradh-probcomp commented 7 years ago

Kinda rude to ask for feedback and then close the issue without waiting for any!

This should do it:

%load_ext jupyter_probcomp.magics
%matplotlib inline
%vizgpm inline
%bayesdb test.bdb
%bql create table t as select * from sqlite_master
%bql create population p for t with schema (guess (*); model Tbl_Name as nominal)
%bql create metamodel m for p with baseline crosscat
%bql .interactive_pairplot --population=p estimate type, tbl_Name from p
riastradh-probcomp commented 7 years ago

It's possible that won't do it (I don't have a setup I can easily test with the bug at the moment) but if it doesn't, then this should instead:

%load_ext jupyter_probcomp.magics
%matplotlib inline
%vizgpm inline
%bayesdb test.bdb
%sql create table t(x, Y)
%sql insert into t values(1,2)
%sql insert into t values(2,4)
%sql insert into t values(3,6)
%bql create population p for t with schema (model x, y as numerical)
%bql create metamodel m for p with baseline crosscat
%bql .interactive_pairplot --population=p estimate * from p
fsaad commented 7 years ago

Kinda rude to ask for feedback and then close the issue without waiting for any!

@riastradh-probcomp Closed the issue since it was fixed, please refer to https://github.com/probcomp/iventure/commit/abf56460a69d0771bc6e6e1ceb5211190abe7aeb.

riastradh-probcomp commented 7 years ago

OK, sorry, didn't realize that. (Always helpful to cite the commit that fixes an issue in a comment closing it!)

riastradh-probcomp commented 7 years ago

Oh, pfeh. I am sorry; you did cite the commit automagically and I just didn't read closely enough.