search

probe-lab / go-kademlia

Generic Go Kademlia implementation
Other
17 stars 4 forks source link

Drop GetPublicKey(peer.ID)? #21

Open guillaumemichel opened 1 year ago

guillaumemichel commented 1 year ago

https://github.com/libp2p/go-libp2p-kad-dht is implementing a public GetPublicKey(peer.ID) method. It isn't the role of the DHT to provide such a feature.

https://github.com/libp2p/go-libp2p-kad-dht/blob/978cb74f5fdf846e09d5769bb4dfb9f962135c38/records.go#L19-L78

IMO this function doesn't need to be ported to the new implementation. If needed this function should be implemented directly in https://github.com/ipfs/boxo.

guillaumemichel commented 1 year ago

2023-06-27 call: there was an agreement that the GetPublicKey function doesn't belong to the DHT implementation, and should NOT be implemented in this repository

yiannisbot commented 1 year ago

Given the above, does this mean that this issue can be closed from here? AFAIU, this is needed, but not in this repo and instead it's needed in: https://github.com/ipfs/boxo - @jorropo do we have a tracking issue in boxo?