search

probe-lab / hermes

A Gossipsub listener and tracer.
Other
29 stars 5 forks source link

feat: PeerDAS #35

Open samcm opened 4 months ago

samcm commented 4 months ago

Actually I'll close this and reopen it when the devnets/spec is a little more stable 😅

barnabasbusa commented 3 months ago

Pls reopen

codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0.66445% with 299 lines in your changes missing coverage. Please review.

Project coverage is 2.88%. Comparing base (b94d32c) to head (113a74f). Report is 143 commits behind head on main.

Files with missing lines Patch % Lines
eth/fetch.go 0.00% 87 Missing :warning:
eth/network_config.go 0.00% 76 Missing :warning:
eth/topic_score_params.go 0.00% 46 Missing :warning:
eth/pubsub.go 0.00% 34 Missing :warning:
cmd/hermes/cmd_eth.go 0.00% 32 Missing :warning:
eth/node_config.go 0.00% 13 Missing :warning:
cmd/hermes/cmd_eth_chains.go 0.00% 9 Missing :warning:
eth/prysm.go 50.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #35 +/- ## ======================================== - Coverage 7.75% 2.88% -4.87% ======================================== Files 7 30 +23 Lines 400 4122 +3722 ======================================== + Hits 31 119 +88 - Misses 361 3992 +3631 - Partials 8 11 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cortze commented 3 months ago

@samcm is this ready for review?

samcm commented 3 months ago

Sorry for the run-around @cortze - it's not at the moment. It's probably not far from the mark but IMO we're still too early on peerdas for this to hit any main branches. Feel free to close again, or leave open until we're closer to a finalized spec.

@barnabasbusa has been sentenced to 15 years of relentless YAML engineering in the DevOps dungeon with no LLM privileges. With good behaviour he'll have the opportunity to rejoin us here in the application layer after 10 years 😆

cortze commented 3 months ago

No worries at all @samcm , just give me a ping whenever this is ready for testing or for a review, or whenever @barnabasbusa gets granted his "conditional release" 🤣