search

probe-lab / zikade

A Go implementation of the libp2p Kademlia DHT specification
Other
11 stars 3 forks source link

Remove StartSpan function from `tele` package #32

Open iand opened 1 year ago

iand commented 1 year ago

Migrated from https://github.com/libp2p/go-libp2p-kad-dht/issues/927

We should remove this function: https://github.com/libp2p/go-libp2p-kad-dht/blob/e86381e824dd2797cf931f14070292fe763a0c93/v2/tele/tele.go#L133

Instead we should plumb a tracer through to the pool/probe/etc.

Context: https://github.com/libp2p/go-libp2p-kad-dht/pull/924#discussion_r1330083744