search

probe-lab / zikade

A Go implementation of the libp2p Kademlia DHT specification
Other
8 stars 3 forks source link

chore: rename PooledQueryBehaviour to QueryBehaviour #65

Closed iand closed 9 months ago

iand commented 9 months ago

Just simplifies this name a bit since we don't currently have a non-pooled query behaviour

dennis-tra commented 9 months ago

Makes sense and looks good 👍

dennis-tra commented 9 months ago

The changeset does not contain any changes to code comments (only the immediate function comments). I don't know if we mentioned the "PooledQueryBehaviour" somewhere but perhaps worth checking if you haven't already done so. I'm thinking of the extensive prose we put above some interfaces.

iand commented 9 months ago

The changeset does not contain any changes to code comments (only the immediate function comments). I don't know if we mentioned the "PooledQueryBehaviour" somewhere but perhaps worth checking if you haven't already done so. I'm thinking of the extensive prose we put above some interfaces.

https://github.com/plprobelab/zikade/pull/65/files#diff-1a93358e6a0a163ecc719f914964fa26560aa803d6a9bdc42bf6e7fb059412d4R110 and https://github.com/plprobelab/zikade/pull/65/files#diff-1a93358e6a0a163ecc719f914964fa26560aa803d6a9bdc42bf6e7fb059412d4R140 are code comments with changes

dennis-tra commented 9 months ago

Sorry, I added my qualifier only the immediate function comments a few seconds after I posted the comment.

dennis-tra commented 9 months ago

Let's merge 👍