probe-rs / rtt-target

Target side implementation of the RTT (Real-Time Transfer) I/O protocol
MIT License
123 stars 30 forks source link

v0.4.0 - feature cortex-m not available #33

Closed kolbma closed 1 year ago

kolbma commented 1 year ago

You have removed the features (e.g. cortex-m) in the new version, but you are checking for with cfg in code for it: https://github.com/probe-rs/rtt-target/blob/4d8bdd8e371f0701595dbfed0b185db188516c2e/rtt-target/src/debug.rs#L26-L30

werediver commented 1 year ago

This issue renders "rtt-target" v0.4.0 (the latest at the moment) unusable, at least on Cortex-M targets 😞

Also notice that v0.4.0 declares no feature-flags at all: https://docs.rs/crate/rtt-target/0.4.0/features

nickmertin commented 1 year ago

I am having this issue as well. Attempting to build a binary against it results in linker errors for undefined symbols _critical_section_1_0_acquire and _critical_section_1_0_release.