probe-rs / rusty-probe

91 stars 13 forks source link

UART pinout for vcp is incorrect #5

Closed allexoll closed 2 years ago

allexoll commented 2 years ago

currently dir_vcp_rx/tx is on gpio25/24, and vcp_rx/tx on 18/19.

The issue is that 18/19 only have cts/rts capabilities on the rp2040, but not rx/tx.

image

but gpio24/25 have uart1 rx/tx capabilities:

Screenshot 2022-09-30 at 10 26 18

i think just switching the two pinset would be enough for VCP to work. I currently have a start of impl for the vcp (using core1 since DMA has not yet landed in the hal), but it will need the correct pins for this to work.

korken89 commented 2 years ago

Hi, thanks for reporting!

I have moved the pins to 20 and 21 in the latest commit: image