Fix #15: debugging session closes silently

noppej commented 2 years ago

This fix for #15 includes the following:

In addition to checking for error code, also check for the possibility of a process signal.
Previously the probe-rs-debugger process was started with child_process.execFile, which has a default maxBuffer for stdio of 1024 * 1024. When the stdout or stderr (RUST_LOG output is handled this way) exceeded this, VSCode would terminate the process and truncate the output ... and because we didn't test the signal, we never saw the SIGTERM event happening, and it looked as if the probe-rs-debugger failed silently. I have changed this to use child_process.spawn, which uses Stream objects instead of Buffer objects to handle the stdio from the child process.
Bump the version number of the extension to 0.3.3

noppej commented 2 years ago

I am waiting for the original reporter of this problem to test that this fix closes #15.

noppej commented 2 years ago

I am waiting for the original reporter of this problem to test that this fix closes #15.

The user confirmed that this fix now reports the errors correctly, and resolves the "silent closure" reported in #15

Tiwalun commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Build succeeded:

probe-rs / vscode