Start using prettier - Githubissues

probe-rs / vscode

VSCode debug extension for probe-rs. It uses the MS DAP protocol to communicate directly with the probe (via probe-rs), and supports basic command line debugging in addition to VSCode UI.

https://probe.rs/

Other

65 stars 6 forks source link

Start using prettier #32

Closed dbrgn closed 2 years ago

dbrgn commented 2 years ago

Automatic code formatting with prettier gives us consistent code style without the need for any stylistic discussions.

When using the recommended VSCode extension, code is automatically formatted on save.

Adherence to the prettier code style is checked in CI.

First part of #20.

Yatekii commented 2 years ago

Thank you for using 4 spaces :) And the PR ofc =D

dbrgn commented 2 years ago

Ok, after an initial mis-configuration, this should now work (including autoformatting on save).

The configuration is totally open for discussion, I based this on another project.

dbrgn commented 2 years ago

Ugh, it seems that prettier has some issues on windows? 🙄 I'm guessing line endings.

dbrgn commented 2 years ago

There we go.

Yatekii commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Build succeeded:

noppej commented 2 years ago

@Yatekii and @dbrgn I know this might be too late, since this has been merged, but I have two challenges with this:

We should not reformat src/debugProtocol.json ... this file is downloaded from the DAP spec in one of the npm scripts.
I would have preferred if we could have delayed merging this until after @Yatekii has reviewed and merged #31 ... the premature merging of this has caused some extensive conflicts in #31.

noppej commented 2 years ago

@dbrgn We've merged #31. It would be awesome if you are able to re-submit these changes :)

PS. I've moved the offending debugProtocol.json from src folder to dap folder.