Revert "Start using prettier"

probe-rs / vscode

VSCode debug extension for probe-rs. It uses the MS DAP protocol to communicate directly with the probe (via probe-rs), and supports basic command line debugging in addition to VSCode UI.

https://probe.rs/

Other

65 stars 6 forks source link

Revert "Start using prettier" #33

Closed Yatekii closed 2 years ago

Yatekii commented 2 years ago

Reverts probe-rs/vscode#32

@dbrgn ... bringing forward my requests from #32:

Please can we ensure we do not reformat src/debugProtocol.json ... this file is downloaded from the DAP spec in one of the npm scripts.
I really appreciate the work you've done here, but I'd prefer if we can hold of a few days with merging this, until #31 has been merged (just to avoid unnecessary conflict resolution on the latter).

dbrgn commented 2 years ago

Regarding #31, it should be easy to resolve the conflicts this way:

Check out the branch
Copy over .prettierrc.yml
Reformat the modified files with npx prettier -w <path-to-file>
Amend the commit

Afterwards, you should be able to rebase without conflicts.

Regarding the other request with the debug protocol: Thanks, I wasn't aware of the file's origin. It should be easy to revert just that file.

I think resolving the conflicts and reverting the formatting of src/debugProtocol.json would be easier than reverting the entire formatting change and re-applying it later. But if you'd prefer that, that would work as well.

noppej commented 2 years ago

No worries. Thank you for being understanding about the revert on your excellent submission.

Also, the src/ is probably not the right location for me to have stored debugProtocol.json - we should consider moving it :)

noppej commented 2 years ago

Merging this revert, so that #31 can go through.

bors r+

bors[bot] commented 2 years ago

:-1: Rejected by too few approved reviews

noppej commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Build succeeded: