Should flashingEnabled default to false when request type is launch?

probe-rs / vscode

VSCode debug extension for probe-rs. It uses the MS DAP protocol to communicate directly with the probe (via probe-rs), and supports basic command line debugging in addition to VSCode UI.

https://probe.rs/

Other

65 stars 6 forks source link

Should flashingEnabled default to false when request type is launch? #41

Closed MabezDev closed 1 year ago

MabezDev commented 1 year ago

Imo it should, it doesn't make sense to flash a target you're trying to attach to.

noppej commented 1 year ago

Great point. Does it even make sense to allow support flashing for "attach"?

Yatekii commented 1 year ago

No I would not support that case :) I think we can get rid of flashingEnabled alltogether :)