search

probe-rs / vscode

VSCode debug extension for probe-rs. It uses the MS DAP protocol to communicate directly with the probe (via probe-rs), and supports basic command line debugging in addition to VSCode UI.
https://probe.rs/
Other
65 stars 5 forks source link

Update or remove(if appropriate) incorrect defaults. #77

Closed bugadani closed 6 months ago

bugadani commented 6 months ago

Closes #75 because the root cause of it was an incorrect assumption made from incorrect defaults.

Yatekii commented 6 months ago

He just synchronized the VSCode config schema with the actual default values we use :)

noppej commented 6 months ago

Github is so strange. I looked at the changes just before typing that comment, and there were no changes to the default in package.json ... just the dependency updates.

I looked again, and they are all there.

noppej commented 6 months ago

The code changes looks fine, and I'm happy to approve. However, if we release this PR, the docs will contradict the product.

Yatekii commented 6 months ago

Tbh, this is the docs. If you configure stuff you look at the autocompletion of vscode :)

noppej commented 6 months ago

I'd be OK if we decide to rip relevant pieces where contradictions exist, from the docs? It makes more sense now that intellisense actually works (courtesy of @bugadani efforts ☺️)

bugadani commented 6 months ago

For some cases the defaults made no sense to me. For example, the SVD path - if it's not set, probe-rs just doesn't use it instead of defaulting to whatever the extension specified. Program binary is required, so a default again makes little sense to me. Forgot to sack npx, sorry about that