search

probml / dynamax

State Space Models library in JAX
https://probml.github.io/dynamax/
MIT License
696 stars 81 forks source link

Refactor HMM model code to separate initial, transition, and emission components #247

Closed slinderman closed 2 years ago

slinderman commented 2 years ago

This PR refactors the HMM modeling code into three components: initial distributions, transition distributions, and emission distributions. This aims to simplify the class hierarchy and allow for plug-and-play models. For example, a user should easily be able to construct an HMM with input-driven transitions and Gaussian emissions.

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

murphyk commented 2 years ago

This is so much nicer! I will merge now, before we start adding types :)