probml / dynamax

State Space Models library in JAX
https://probml.github.io/dynamax/
MIT License
667 stars 76 forks source link

Parameter refactor v4 #255

Closed slinderman closed 1 year ago

slinderman commented 1 year ago

Some pretty big changes in here...

I tried a few ways of combining parameters and their properties into one object, but in the end I think this is the most transparent approach. I converted them all to NamedTuple, which seems like JAX best practice. Note that props are still mutable, which could in theory cause some problems if you jit a function that closes over ParameterProperties and then change them.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

murphyk commented 1 year ago

Looks great! (See comments in slack.) There are 2 failing tests, but I will merge anyway, and we can resolve this later.

Screen Shot 2022-11-09 at 11 10 02 AM