Closed slinderman closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Looks great! (See comments in slack.) There are 2 failing tests, but I will merge anyway, and we can resolve this later.
Some pretty big changes in here...
params
andprops
toNamedTuple
schex
dependencyto/from_unconstrained
to usetree_map
log_det_jacobian_constrain
to usetree_map
NamedTuple
sI tried a few ways of combining parameters and their properties into one object, but in the end I think this is the most transparent approach. I converted them all to
NamedTuple
, which seems like JAX best practice. Note that props are still mutable, which could in theory cause some problems if you jit a function that closes overParameterProperties
and then change them.