search

probml / dynamax

State Space Models library in JAX
https://probml.github.io/dynamax/
MIT License
667 stars 76 forks source link

Patch GaussianHMM ipynb #294

Closed emdupre closed 1 year ago

emdupre commented 1 year ago

Follow-up on #292 , cc @slinderman

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

emdupre commented 1 year ago

I'm getting a dependency error. The patch here shouldn't interact with any environmental states, so just flagging that this might be a test environment issue !

emdupre commented 1 year ago

I believe the issue was introduced in 4052112ca0d07c7d9120d45fd6461a07d9ded2dc and is from this import as the library no longer includes tqdm as a dependency despite its import in generalized_gaussian_ssm.dekf.utils. I guess this file wasn't being tested before and so this wasn't caught !

~Let me know if you'd like me to clean up that import (by adding tqdm, which I assume is the preferred route forward ?) in this PR so the tests pass, or if you'd like to handle it separately !~

EDIT : Just noticed that this was already raised in #293 !