probml / pml2-book

Probabilistic Machine Learning: Advanced Topics
MIT License
1.39k stars 119 forks source link

Possible issue in eq 36.115 #275

Closed Duane321 closed 1 year ago

Duane321 commented 1 year ago

Edition: 2023-04-01, Advanced Topics

I could merely be confused, but it seems there is a mismatch between the equations in red:

image

Shouldn't p(a) appear in 36.115? It seems like we might be trying to accomplish that with 1/|A|, but I don't believe 1/|A| = p(a)

murphyk commented 1 year ago

I'm not sure. I'll ask @vveitch

vveitch commented 1 year ago

Yes, this is a typo. (There should be a hat{p}(a) in the estimator in the same position as p(a) in the estimand). I'll fix it tonight.

murphyk commented 1 year ago

Hi @vveitch .I'm currently doing a pass of bug fixes, I will check in the source latex by EOD, please ping me before pulling :)

vveitch commented 1 year ago

in that case, I'll just do tomorrow morning :)

On Mon, Aug 14, 2023 at 2:49 PM Kevin P Murphy @.***> wrote:

Hi @vveitch https://github.com/vveitch .I'm currently doing a pass of bug fixes, I will check in the source latex by EOD, please ping me before pulling :)

— Reply to this email directly, view it on GitHub https://github.com/probml/pml2-book/issues/275#issuecomment-1677963409, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZZFQWPWHN3EOKSPD773DDXVJ6K3ANCNFSM6AAAAAA22JBZCQ . You are receiving this because you were mentioned.Message ID: @.***>

murphyk commented 1 year ago

I just committed all the changes. Please check your email for some more context :)

murphyk commented 1 year ago

fixed