probml / pml2-book

Probabilistic Machine Learning: Advanced Topics
MIT License
1.4k stars 119 forks source link

Issue in Gibbs sampling for Ising models (page 501), version 2023-08-15 #290

Closed davideC00 closed 4 months ago

davideC00 commented 1 year ago

Hi,

there is an issue in the highlighted phrase: image

If $x_i \in \{0,1\}$, the conditional distribution in the equation 12.27 is $σ(2J(a_i-d_i))$. I think the problem is that the definition $\eta_i=x_i(a_i-d_i)$ works only if $x_i\in \{-1,1\}$ but it is has been used also for the case $x_i \in \{0,1\}$

davideC00 commented 1 year ago

Also here:

image

It should be a plus sign

murphyk commented 4 months ago

thanks! Fixed.