search

probml / pmtk3

Probabilistic Modeling Toolkit for Matlab/Octave.
MIT License
1.55k stars 797 forks source link

Parameters are not set in condDiscreteProdCpdFit #128

Closed flokadillo closed 3 months ago

flokadillo commented 7 years ago

There seems to be a small error in GraphicalModels/cpd/condDiscreteProdCpdCreate.m. In function condDiscreteProdCpdFit, the variable T is computed but is not returned. I guess we should add a line saying CPD.T = T; to the end of the function.

murphyk commented 7 years ago

Please make a pull request with the bug fix.

On Mon, Jan 30, 2017 at 4:56 AM, flokadillo notifications@github.com wrote:

There seems to be a small error in GraphicalModels/cpd/ condDiscreteProdCpdCreate.m. In function condDiscreteProdCpdFit, the variable T is computed but is not returned. I guess we should add a line saying CPD.T = T; to the end of the function.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/probml/pmtk3/issues/128, or mute the thread https://github.com/notifications/unsubscribe-auth/AEavEFyEWJcSQGfYWtdHu156DoMMvGZlks5rXd3-gaJpZM4LxXuT .

flokadillo commented 3 months ago

closing due as the issue is quite old now