search

probml / pmtk3

Probabilistic Modeling Toolkit for Matlab/Octave.
MIT License
1.55k stars 797 forks source link

A trivial bug. A typo in loadData. On line 81. #75

Closed alexgmcm closed 10 years ago

alexgmcm commented 10 years ago

As I described in the issue I raised - Line 81 in loadData.m uses the incorrect quote mark, which then means the %s doesn't work as intended and instead comments out the rest of the line resulting in a script failure and this then causes testpmtk3.m to ask you to check internet connection or perl installation.

fprintf("%s exists, no need to download",dest);

should be:

fprintf('%s exists, no need to download',dest);

That fixed the problem for me. So I have submitted this pull request.

Sorry if this isn't the correct way to do this - I'm kind of new.

Many thanks,

Alexander.

murphyk commented 10 years ago

There is a bigger problem - the 'stat' function a few lines before isn't even defined. I think this has already been fixed: when I do a pull, I don't get the 'stat', nor do I get the double quotes.

[info,msg,err] = stat(dest);
if (msg == 0)
  fprintf("%s exists, no need to download",dest);
else