search

probml / pyprobml

Python code for "Probabilistic Machine learning" book by Kevin Murphy
MIT License
6.53k stars 1.53k forks source link

latexify hmm_poisson_changepoint.ipynb #1005

Closed TakshPanchal closed 2 years ago

TakshPanchal commented 2 years ago

Description

Figure Number

Figure 29.6, 29.7 and 29.8

Figures

Figure 29.6

Before PR After PR
29.6B 29.6A

Figure 29.7

Before PR After PR
Screenshot from 2022-07-13 15-31-57 29.7

Figure 29.8

Before PR After PR
Screenshot from 2022-07-13 15-37-24 Screenshot from 2022-07-13 15-37-08

Issue

739

Steps

Checklist:

Potential problems/Important remarks

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

karm-patel commented 2 years ago

Dr. @murphyk, is this little spike ok, or is it some problem? @TakshPanchal tried to reproduce the figure but couldn't able to do that. image

murphyk commented 2 years ago

This version of the notebook is deprecated, and will be replaced by a pointer to https://github.com/probml/ssm-jax/blob/main/ssm_jax/hmm/demos/poisson_hmm_changepoint.ipynb. Please can you apply your latexifcation to the latter and make a PR on ssm-jax?

The current notebook should be renamed hmm_poisson_changepoint_distrax and moved to supplementary.