search

probml / pyprobml

Python code for "Probabilistic Machine learning" book by Kevin Murphy
MIT License
6.45k stars 1.52k forks source link

Feat: adf_logistic_regression_demo.ipynb #1076

Closed gerdm closed 2 years ago

gerdm commented 2 years ago
review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

murphyk commented 2 years ago

This looks good, but please remove the dependence on https://github.com/probml/JSL/blob/main/jsl/demos/logreg_biclusters.py. (JSL will eventually be deprecatd). Ideally this notebook should be self contained, just like https://github.com/probml/pyprobml/blob/master/notebooks/book1/10/logreg_laplace_demo.ipynb. Also, for simplicity, maybe just compare to Laplace and ignore mcmc?