search

probml / pyprobml

Python code for "Probabilistic Machine learning" book by Kevin Murphy
MIT License
6.45k stars 1.52k forks source link

Minor bug in computing the energy of ising demo. #1106

Closed lkhphuc closed 1 year ago

lkhphuc commented 1 year ago

The contribution of the lower y pixel is assigned to an unused variable a instead of to wi.

Description

Figure Number

book2 Figure 4.17

Figures

Before PR After PR
image image
image image
image image

Issue

Checklist

Potential problems/Important remarks

At J=0.4 the updated PR has more "clumpiness" than original, but the phase transition for this model is ~0.44 per Eq. 4.79

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Neoanarika commented 1 year ago

I checked the changes. I agree with there was a bug and that the PR corrected the mistake. Thanks on the Gibbs Ising code.