probml / pyprobml

Python code for "Probabilistic Machine learning" book by Kevin Murphy
MIT License
6.53k stars 1.53k forks source link

Added grid approximation #968

Closed karm-patel closed 2 years ago

karm-patel commented 2 years ago

Description

  1. Added grid approximation (code by Prof. @nipunbatra ) in notebooks/book1/04/laplace_approx_beta_binom_jax.ipynb which is also used in Book2
  2. notebooks/book2/07/advi_beta_binom_pymc.ipynb: Converted pymc3 to pymc4
  3. notebooks/book1/04/laplace_approx_beta_binom_pymc4.ipynb: currently this version is not working due to issue: https://github.com/pymc-devs/pymc/issues/5443, So I have also kept pymc3 version for the same.

Figure Number

Book2: 7.2 Book1: 4.22

Figures

Before PR: image

After PR: image

Issue

943

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

murphyk commented 2 years ago

Needs black formatting :)

karm-patel commented 2 years ago

Needs black formatting :)

My bad! Fixed it.